View Bug Details

IDProjectCategoryView StatusLast Update
0001227DCP-o-maticBugspublic2018-10-17 20:15
Reportercarl Assigned Tocarl  
PriorityhighSeverityblockReproducibilityalways
Status closedResolutionfixed 
Target Version2.12.0 
Summary0001227: Export to Prores broken when image is placed into a container at an odd pixel offset
Description

Prores (going to YUV422P10); colours completely wrong for RGB24 or YUV420P input.
H264 goes to YUV420P; colours right for RGB24 input.
Due to incorrect handling of subsampled pixels in Image::crop_scale_window.

TagsNo tags attached.
Branch
Estimated weeks required
Estimated work requiredUnknown

Activities

carl

2018-03-01 00:40

administrator   ~0002237

Last edited: 2018-03-01 01:02

Except ffmpeg_encoder_basic_test_mov is fine; YUV420P source. All other tests bad.

carl

2018-03-01 01:05

administrator   ~0002238

Not encoding audio doesn't help so it looks like it's not related to the mux.

Carsten

2018-03-01 11:21

manager   ~0002239

Oops. Since when? I recently did a few test with ProRes, both from MP4/MOV sources (Bunny/Sintel) and J2K/DCP, and they worked fine - except for that Space Station Flythrough when downscaling to 2k !?

  • Carsten

carl

2018-03-01 16:13

administrator   ~0002243

Not sure; I'm testing with git head and the colours are totally screwed; a nearly monochrome test image comes out green both on Linux and Mac. mp4 export seems fine. It's a really odd one. I may have to go back and see if I introduced it recently...

carl

2018-03-01 16:44

administrator   ~0002244

On my machine it's broken since at least 2.11.30.

Carsten

2018-03-01 16:53

manager   ~0002245

Can I reproduce this with Bunny or Sintel? I have everything back to 2.11.17 or so.

  • Carsten

carl

2018-03-01 21:28

administrator   ~0002249

I just noticed it only happens with 25fps projects...

Carsten

2018-03-01 21:54

manager   ~0002250

Now that's funny... Prores strictly SMPTE...

  • Carsten

carl

2018-03-01 23:35

administrator   ~0002253

Last edited: 2018-03-02 00:18

@carl it's not even that simple. Forcing all export projects to 24fps (both content and project) does not change the result.

Carsten

2018-03-02 01:18

manager   ~0002254

Tried it with the Bunny Benchmark - looks exactly like what I reported about the ISS Flythrough - greenish, false color, blocking, etc.

I know that I tried a couple of exports in different configurations, and did not experience this, but I also tried dcp->Prores...

Quick check:

trailer_480p.mov (25) to 25fps Prores - false colours
trailer_480p.mov (25) to 24fps Prores - false colours
trailer_480p.mov (25) to 24fps MP4 - correct
24fps MP4 to 24fps Prores - correct
24fps MP4 to 25fps Prores - correct

'to 24/25fps' means 'DCP frame rate' set to 24/25 fps

NOW - that ISS flythrough creates the same false color appearance when exported - but it is 29,97.

sigh...

  • Carsten

carl

2018-03-02 01:32

administrator   ~0002255

Thanks. I think I've got it now: it was caused by pillarboxing into containers at an odd pixel offset. Should be OK in 2.11.69. Thanks for the testing.

Carsten

2018-03-02 01:36

manager   ~0002257

Last edited: 2018-03-02 10:52

Just tried with 2.11.17 OS X - same result. It may have been there right from the start?!

But it only happens from some non-DCP/j2k content to Prores. No problem to create a Prores from a 25fps BunnyDCP.

Edit: No wonder since DCPs show no odd pixel offsets...

  • Carsten

Carsten

2018-03-02 01:38

manager   ~0002258

Who was that ignorant jerk again who said that export is as simple as grabbing the images that are already in the J2K processing pipeline?

  • Carsten

Bug History

Date Modified Username Field Change
2018-03-01 00:35 carl New Bug
2018-03-01 00:40 carl Note Added: 0002237
2018-03-01 01:02 carl Note Edited: 0002237
2018-03-01 01:02 carl Priority normal => high
2018-03-01 01:02 carl Severity minor => block
2018-03-01 01:05 carl Note Added: 0002238
2018-03-01 11:21 Carsten Note Added: 0002239
2018-03-01 16:13 carl Note Added: 0002243
2018-03-01 16:44 carl Note Added: 0002244
2018-03-01 16:53 Carsten Note Added: 0002245
2018-03-01 21:28 carl Summary Export to prores completely broken => Export to Prores @ 25fps broken
2018-03-01 21:28 carl Description Updated
2018-03-01 21:28 carl Note Added: 0002249
2018-03-01 21:54 Carsten Note Added: 0002250
2018-03-01 23:35 carl Note Added: 0002253
2018-03-01 23:57 carl Note Edited: 0002253
2018-03-02 00:18 carl Note Edited: 0002253
2018-03-02 01:18 Carsten Note Added: 0002254
2018-03-02 01:30 carl Summary Export to Prores @ 25fps broken => Export to Prores broken when image is placed into a container at an odd pixel offset
2018-03-02 01:30 carl Description Updated
2018-03-02 01:32 carl Assigned To => carl
2018-03-02 01:32 carl Status new => resolved
2018-03-02 01:32 carl Resolution open => fixed
2018-03-02 01:32 carl Note Added: 0002255
2018-03-02 01:36 Carsten Note Added: 0002257
2018-03-02 01:38 Carsten Note Added: 0002258
2018-03-02 10:51 Carsten Note Edited: 0002257
2018-03-02 10:52 Carsten Note Edited: 0002257
2018-10-17 20:15 carl Status resolved => closed