View Bug Details

IDProjectCategoryView StatusLast Update
0000582DCP-o-maticFeaturespublic2018-10-17 20:15
Reportercarl Assigned Tocarl  
PriorityhighSeverityfeatureReproducibilityhave not tried
Status closedResolutionfixed 
Summary0000582: Support FFmpeg content with no video stream
Description

[]

TagsNo tags attached.
Branch
Estimated weeks required
Estimated work requiredAverage

Relationships

has duplicate 0000552 closedcarl Allow use of non-video files decoded by FFmpeg 
has duplicate 0000743 closedcarl Can't load .mxf .mkv .mka audio-only files 
has duplicate 0000834 closedcarl Unable to load audio from mp3 m4a files when making an audio only DCP 
related to 0000498 closedcarl libsndfile refuses to read PATRONSPIRITS_NUMBEREDSIGNEDSTAMPS_51AUDIO.wav 

Activities

carl

2015-09-06 01:12

administrator   ~0000850

Last edited: 2015-09-06 22:28

The initial question is what to do about the fact that FFmpegContent may no longer have video, so all its inherited VideoContent methods need to be made optional<> as they might not be relevant.

This suggests that perhaps FFmpegContent should have-a VideoContent/AudioContent/SubtitleContent (as a pointer) which could be null if there is no video/audio/subtitle. This would make the presence/lack of video more neatly expressed at runtime.

That approach stumbles first on the pure virtual AudioContent::audio_streams which we really want to override in SingleStreamAudioContent and FFmpegContent. I guess with that you put a std::vector<AudioStreamPtr> in the AudioContent and the owning classes fill that in.

carl

2015-09-07 15:23

administrator   ~0000853

  1. Use more boost_foreach
  2. Remove sndfile content / decoder
  3. Remove SingleStreamAudioContent and put it in DCPContent
  4. Remove AudioExaminer and put it in DCPContent
  5. Move set_video_length and set_video_frame_rate into VideoContent from ImageContent
  6. Split to has-a from is-a for video/audio/subtitle content.
  7. Rename methods in video/audio/subtitle content.
  8. Back-compat sndfile.

carl

2016-07-04 13:51

administrator   ~0001331

This has been done on the way to 2.9.0.

Bug History

Date Modified Username Field Change
2015-05-26 14:05 carl New Bug
2015-05-26 15:13 carl Assigned To => carl
2015-05-26 15:13 carl Status new => acknowledged
2015-06-10 18:51 carl Relationship added related to 0000498
2015-06-12 12:20 carl Severity minor => feature
2015-06-12 13:57 carl Estimated work required => Average
2015-06-12 13:58 carl Relationship added has duplicate 0000552
2015-09-04 10:05 carl Priority normal => high
2015-09-04 10:05 carl Target Version 2.x => 2.4.0
2015-09-06 01:12 carl Note Added: 0000850
2015-09-06 22:28 carl Note Edited: 0000850
2015-09-07 15:23 carl Note Added: 0000853
2015-09-30 16:04 carl Target Version 2.4.0 => 2.5.0
2015-11-04 00:54 carl Target Version 2.5.0 =>
2015-11-10 00:58 carl Relationship added has duplicate 0000743
2016-04-01 20:16 carl Relationship added has duplicate 0000834
2016-07-04 13:51 carl Note Added: 0001331
2016-07-04 13:51 carl Status acknowledged => resolved
2016-07-04 13:51 carl Resolution open => fixed
2018-10-17 20:15 carl Status resolved => closed