View Bug Details

IDProjectCategoryView StatusLast Update
0003041DCP-o-maticFeaturespublic2025-06-02 10:33
ReporterNKB Assigned Tocarl  
PrioritynormalSeverityfeatureReproducibilityN/A
Status feedbackResolutionopen 
Platform64-bitOSWindowsOS Version11
Product Version2.18.18 
Summary0003041: please add a "crop output to [aspect ratio]" feature to the player
Description

please add a "crop output to [aspect ratio]" feature to the dcpomatic player!
please give it a selection of often encountered defaults (125, 133, 137, 150, 166, 178, 185, 190, 200, 221, 235, 239) as well as an arbitrary (user definable) option.
ensure the subtitles/captions are handled accordingly.
the cherry on top would be if the cropping could be set by-item in playlists <3 !

Additional Information

willing to pay.

Tagsgit, paid
Branch3041-player-crop
Estimated weeks required
Estimated work requiredUndecided

Activities

carl

2025-05-13 14:46

administrator   ~0006981

Perhaps you could get in touch with your rough budget

carl@dcpomatic.com

carl

2025-05-13 16:31

administrator   ~0006982

I guess you mean for these ratios to be handled like DCPs, so 185 crops to 1998x1080 (in 2K) and 239 crops to 2048x858, for example?

When you say "subtitle/captions handled accordingly" you mean they should also be cropped where appropriate? (e.g. if I play a subtitled 1.85 DCP cropped to 2.39)?

NKB

2025-05-13 17:24

reporter   ~0006983

i would like the (fullscreen) active area output to be croppable.
to give an example: i receive many 178 films dci-compliantly containered in 185. my non-dci-compliant monitor/projector (with native aspect ratio 178) will render these (fullscreen) scaled down (gasp!) with black borders all around. that's extremely irritating since i could render the entire active area pixel-perfect if only that dang pillarbox were cropped away.

regarding the subs/captions, another example: some silly person sent me a scope (or netflixy-aspect ratio) movie containered in letterboxed flat with the subtitles moved way up into the active area. the desired cropping should maintain the original position (if handled in percent, this might be affected if calculated relative to the cropped image dimensions) and font size (probably no issue) of the subtitles.

carl

2025-05-30 22:48

administrator   ~0006998

@NKB understood, thanks!

carl

2025-05-30 22:52

administrator   ~0006999

@carl this is a little awkward because it requires cropping of J2K sources, which is currently not supported by the OpenGL backend.

carl

2025-05-30 23:55

administrator   ~0007000

Last edited: 2025-05-30 23:56

@carl

shankly:~/src/dcpomatic [3041-player-crop] $ git diff
diff --git a/src/tools/dcpomatic_player.cc b/src/tools/dcpomatic_player.cc
index 43c071556..0a37aedc5 100644
--- a/src/tools/dcpomatic_player.cc
+++ b/src/tools/dcpomatic_player.cc
@@ -488,7 +488,8 @@ public:
                }

                /* Start off as Flat */
-               _film->set_container (Ratio::from_id("185"));
+               // _film->set_container (Ratio::from_id("185"));
+               _film->set_container(Ratio::from_id("133"));

                _film->set_audio_channels (MAX_DCP_AUDIO_CHANNELS);

@@ -547,6 +548,8 @@ public:
                                        ++id;
                                }
                        }
+
+                       _film->content()[0]->video->set_crop(Crop{281, 281, 0, 0});
                }
        }

works for 1.33 content in the simple renderer.

carl

2025-06-01 10:04

administrator   ~0007001

Please could you try this test version and see if it works for you?

https://dcpomatic.com/temp/3041-player-crop/12624b7/DCP-o-matic%2012624b734%2064-bit%20Installer.exe

Let me know if you need to run it on macOS/Linux.

NKB

2025-06-02 07:40

reporter   ~0007003

Thank you very much. I will hopefully get around to testing it today.
Yes, I'd like to run it on macOS 10.10 and higher (Sequoia) and Mint 22.
Also, one quirk I noticed right away: The checkbox in the preferences gets disabled once you uncheck it.

carl

2025-06-02 09:13

administrator   ~0007004

Last edited: 2025-06-02 10:33

Thanks, I fixed the checkbox problem. Here are some builds:

Bug History

Date Modified Username Field Change
2025-05-13 09:32 NKB New Bug
2025-05-13 14:44 carl Assigned To => carl
2025-05-13 14:44 carl Status new => acknowledged
2025-05-13 14:46 carl Note Added: 0006981
2025-05-13 16:31 carl Status acknowledged => feedback
2025-05-13 16:31 carl Note Added: 0006982
2025-05-13 17:24 NKB Note Added: 0006983
2025-05-13 17:24 NKB Status feedback => assigned
2025-05-30 22:48 carl Note Added: 0006998
2025-05-30 22:48 carl Status assigned => in progress
2025-05-30 22:52 carl Note Added: 0006999
2025-05-30 22:54 carl Branch => 3041-player-crop
2025-05-30 22:54 carl Estimated work required => Undecided
2025-05-30 23:19 carl Tag Attached: git
2025-05-30 23:19 carl Tag Attached: paid
2025-05-30 23:55 carl Note Added: 0007000
2025-05-30 23:56 carl Note Edited: 0007000
2025-05-30 23:56 carl Note Edited: 0007000
2025-06-01 10:04 carl Note Added: 0007001
2025-06-01 10:05 carl Status in progress => feedback
2025-06-02 07:40 NKB Note Added: 0007003
2025-06-02 07:40 NKB Status feedback => assigned
2025-06-02 09:13 carl Note Added: 0007004
2025-06-02 10:33 carl Note Edited: 0007004
2025-06-02 10:33 carl Status assigned => feedback