View Bug Details

Jump to NotesJump to History
IDProjectCategoryView StatusDate SubmittedLast Update
0001454DCP-o-maticBugspublic2019-01-29 13:052020-12-16 00:12
Reportermarto.92 Assigned Tocarl  
PrioritynormalSeveritycrashReproducibilityalways
Status closedResolutionfixed 
Platform64-bitOSWindowsOS Version10
Product Version2.12.x 
Summary0001454: Crash after opening bad .srt file
Description

The program (lastest version today) crashes after opening a .srt file that contains some syntax errors instead of showing an error dialog. Suddenly it crashes and the progress on the proyect cannot be saved.

I know that .srt has some missing lines but another user may not and this could be a problem.

Steps To Reproduce

Edit a valid .srt file in order to make a bad .srt that doesn't follow .srt standard. Next create a new DCP proyect on DCP-o-matic, open a random video file (in my case .mp4) and after that, open the .srt file edited. This should crash the program.

Tagscrash, dcp, srt, subtitles, test-, test-on-windows
Branch
Estimated weeks required
Estimated work requiredUnknown

Activities

carl

2019-01-29 16:52

administrator   ~0002977

Can you please attach an .srt that triggers this?

marto.92

2019-01-29 22:18

reporter   ~0002987

This is the .srt example

subtitulo1.srt (171 bytes)    
1
00:00:05 --> 00:00:08
Un viaje a la playa
Enero 27 2018

2
00:00:10 --> 00:00:16
Llegamos a la playa...

3
00:00:22 --> 00:00:26
Un hermoso paisaje nos recibe
subtitulo1.srt (171 bytes)   

carl

2019-01-29 22:36

administrator   ~0002988

Thank you. This should be fixed in DCP-o-matic 2.12.18 and 2.13.112.

@carl 23d4d5df719e020011686ff9225845ae360f408e in libsub:master.

Bug History

Date Modified Username Field Change
2019-01-29 13:05 marto.92 New Bug
2019-01-29 13:05 marto.92 Tag Attached: dcp
2019-01-29 13:05 marto.92 Tag Attached: subtitles
2019-01-29 13:05 marto.92 Tag Attached: test-
2019-01-29 13:05 marto.92 Tag Attached: test-on-windows
2019-01-29 13:05 marto.92 Tag Attached: crash
2019-01-29 13:05 marto.92 Tag Attached: srt
2019-01-29 16:52 carl Assigned To => carl
2019-01-29 16:52 carl Status new => feedback
2019-01-29 16:52 carl Note Added: 0002977
2019-01-29 22:18 marto.92 File Added: subtitulo1.srt
2019-01-29 22:18 marto.92 Note Added: 0002987
2019-01-29 22:18 marto.92 Status feedback => assigned
2019-01-29 22:36 carl Status assigned => resolved
2019-01-29 22:36 carl Resolution open => fixed
2019-01-29 22:36 carl Note Added: 0002988
2020-12-16 00:12 carl Status resolved => closed