View Bug Details
ID | Project | Category | View Status | Date Submitted | Last Update |
---|---|---|---|---|---|
0001238 | DCP-o-matic | Features | public | 2018-03-11 13:32 | 2018-10-17 20:16 |
Reporter | Carsten | Assigned To | carl | ||
Priority | normal | Severity | minor | Reproducibility | always |
Status | closed | Resolution | fixed | ||
Platform | Mac | OS | OS X | OS Version | 10.11 |
Product Version | 2.11.0 | ||||
Target Version | 2.14.0 | ||||
Summary | 0001238: add dcp file validation (verify hashes) and file completeness | ||||
Description | Maybe add this to the player? That would allow basic integrity checking to protect from copy/media errors.
| ||||
Tags | No tags attached. | ||||
Branch | |||||
Estimated weeks required | |||||
Estimated work required | Unknown | ||||
|
Background done in ccde188f3b560730d14933af5caa11b413c2e623 |
|
hash checking available as 'Verify DCP' in Player 2.13.9 under 'Tools' So, solved. But that 'Verify DCP' needs to become a translatable string, as well as all dialogs that follow. Maybe also add some minimal explanation to what is happening?
|
|
Hmm, is it possible that 'Verify DCP' is just a dummy so far? As to 'Background done'? Because, I manipulated size and hash values in a PKL of Bunny-DCP, but it is still validated OK?
|
|
Ah yes it doesn't cross-check with the PKL. |
|
Also it trips up if the CPL does not have hash tags. |
|
@carl: pkl branch in libdcp has some work on reading PKLs. |
|
Should check PKL hashes as well as CPL ones in 2.13.43, with libdcp commits around 01e08cb5fef34a33524e404ae8e2ad7d029d0a22 |
Date Modified | Username | Field | Change |
---|---|---|---|
2018-03-11 13:32 | Carsten | New Bug | |
2018-03-11 13:32 | Carsten | Status | new => assigned |
2018-03-11 13:32 | Carsten | Assigned To | => carl |
2018-03-14 01:00 | carl | Note Added: 0002295 | |
2018-04-10 23:50 | carl | Relationship added | related to 0000971 |
2018-04-11 16:18 | Carsten | Note Added: 0002359 | |
2018-04-11 16:47 | Carsten | Note Edited: 0002359 | |
2018-04-11 17:00 | Carsten | Note Added: 0002360 | |
2018-04-20 00:58 | carl | Note Added: 0002389 | |
2018-04-20 13:31 | carl | Note Added: 0002393 | |
2018-08-16 23:34 | carl | Note Added: 0002623 | |
2018-08-17 09:43 | carl | Status | assigned => resolved |
2018-08-17 09:43 | carl | Resolution | open => fixed |
2018-08-17 09:43 | carl | Note Added: 0002625 | |
2018-10-17 20:16 | carl | Status | resolved => closed |