View Bug Details

Jump to NotesJump to History
IDProjectCategoryView StatusDate SubmittedLast Update
0001639DCP-o-maticFeaturespublic2019-10-24 22:562020-12-16 00:38
Reportercarl Assigned Tocarl  
PriorityurgentSeverityminorReproducibilityhave not tried
Status closedResolutionfixed 
Target Version2.16.0 
Summary0001639: More comprehensive validation
Description

[]

Tagsmajor
Branch
Estimated weeks required2
Estimated work requiredUndecided

Activities

carl

2019-12-04 23:46

administrator   ~0003626

Last edited: 2020-05-08 23:39

Some ideas:

  • Certificate chain validity (including notBefore/notAfter)
  • ID, date format validities
  • DCI picture dimensions

carl

2019-12-09 22:06

administrator   ~0003631

Schema checking with xerces added in libdcp:xerces branch. Still should do picture dimensions, certificate chain validity, JPEG2000 frame size...

carl

2020-04-17 22:29

administrator   ~0003771

xerces branch merged to master.

carl

2020-05-06 23:20

administrator   ~0003802

Last edited: 2020-05-06 23:21

So the list is now:

  1. picture dimensions
  2. certificate chain validity (signer)
  3. JPEG2000 frame size (bytes)

Anything else?

carl

2020-05-07 00:09

administrator   ~0003803

Some work on frame size checking in libdcp:verify-j2k-sizes

carl

2020-05-07 20:30

administrator   ~0003804

JPEG2000 frame size now in libdcp master.

carl

2020-05-07 21:30

administrator   ~0003805

Last edited: 2020-05-07 21:52

Hacks for certificate chain checking in libdcp:check-chains but this requires going 10 rounds with xmlsec1 which I may not have the energy for. Although it looks like xmlsec1's verify (not unreasonably) wants the cert of the CA which issued the root. What do we actually want to check here? Just that the chain's root signs its intermediate, and so on?

carl

2020-05-07 22:03

administrator   ~0003806

Last edited: 2020-05-08 23:34

XML validity checks on subtitles added in libdcp:1b7394d83f64a8655787d82189c3170a2128c16b

carl

2020-05-17 20:23

administrator   ~0003820

I'll mark this resolved and we can add more specific requests in individual bugs.

Bug History

Date Modified Username Field Change
2019-10-24 22:56 carl New Bug
2019-10-24 22:57 carl Assigned To => carl
2019-10-24 22:57 carl Status new => confirmed
2019-11-27 16:22 carl Tag Attached: major
2019-11-27 22:00 carl Estimated weeks required => 2
2019-11-27 22:00 carl Estimated work required => Undecided
2019-12-04 23:32 carl Summary More comprehensive validation and perhaps a separate validation tool => More comprehensive validation
2019-12-04 23:46 carl Note Added: 0003626
2019-12-09 22:06 carl Note Added: 0003631
2020-04-17 22:29 carl Note Added: 0003771
2020-05-06 23:20 carl Note Added: 0003802
2020-05-06 23:21 carl Note Edited: 0003802
2020-05-07 00:09 carl Note Added: 0003803
2020-05-07 20:30 carl Note Added: 0003804
2020-05-07 21:30 carl Note Added: 0003805
2020-05-07 21:52 carl Note Edited: 0003805
2020-05-07 22:03 carl Note Added: 0003806
2020-05-08 23:34 carl Note Edited: 0003806
2020-05-08 23:39 carl Note Edited: 0003626
2020-05-17 20:23 carl Status confirmed => resolved
2020-05-17 20:23 carl Resolution open => fixed
2020-05-17 20:23 carl Note Added: 0003820
2020-12-16 00:38 carl Status resolved => closed