View Bug Details

IDProjectCategoryView StatusLast Update
0001851DCP-o-maticBugspublic2021-10-08 00:03
Reportercarl Assigned Tocarl  
PriorityimmediateSeverityminorReproducibilityhave not tried
Status closedResolutionfixed 
Target Version2.16.0 
Summary0001851: Need end-to-end video level range tests for different inputs, DCP/export output
Description

[]

TagsNo tags attached.
Branch1851-video-range
Estimated weeks required
Estimated work requiredUndecided

Activities

carl

2020-10-02 00:08

administrator   ~0003954

Last edited: 2020-11-05 21:57

Why doesn't the video waveform even change when you change the range control?

It correctly updates with YUV content, just not with RGB.

What is it showing?

Should be showing the XYZ values that will go into the DCP; calls DCPVideo::convert_to_xyz() which gets its image from PlayerVideo::make_image()

Looks like the return from PlayerVideo::make_image() should always be full-range; call to sws_setColorspaceDetails in Image::crop_scale_window tries to achieve that. Although the comment there says that this method only changes the range from in to out if the image is YUV or grayscale (?!). So presumably image file inputs e.g. DPX will not be changed; which is OK if they are already full range.

carl

2020-11-05 21:35

administrator   ~0003992

Last edited: 2020-11-05 21:58

But if the video range control is going to work for all input types we need to do the transformation ourselves for non isYUV/isGray images; i.e. basically RGB i.e. still images. Could try adding a filter to the FFmpeg decoder

perhaps -vf scale=in_range=limited:out_range=full

or just do it ourselves (but would require a method for each supported pixel format).

carl

2020-11-15 19:55

administrator   ~0003997

Last edited: 2020-11-16 00:42

d346fe3112a503433b791b04f65891beb9bd39d8

Bug History

Date Modified Username Field Change
2020-10-01 00:27 carl New Bug
2020-10-02 00:08 carl Note Added: 0003954
2020-11-05 21:20 carl Note Edited: 0003954
2020-11-05 21:20 carl Note Edited: 0003954
2020-11-05 21:22 carl Note Edited: 0003954
2020-11-05 21:23 carl Note Edited: 0003954
2020-11-05 21:35 carl Note Added: 0003992
2020-11-05 21:41 carl Note Edited: 0003992
2020-11-05 21:57 carl Note Edited: 0003954
2020-11-05 21:57 carl Note Edited: 0003954
2020-11-05 21:58 carl Note Edited: 0003992
2020-11-08 21:37 carl Branch => 1851-video-range
2020-11-08 21:37 carl Estimated work required => Undecided
2020-11-15 19:55 carl Assigned To => carl
2020-11-15 19:55 carl Status new => resolved
2020-11-15 19:55 carl Resolution open => fixed
2020-11-15 19:55 carl Note Added: 0003997
2020-11-16 00:42 carl Note Edited: 0003997
2021-10-08 00:03 carl Status resolved => closed