View Bug Details

IDProjectCategoryView StatusLast Update
0002126DCP-o-maticGeneralpublic2024-03-22 22:21
Reportercarl Assigned Tocarl  
PrioritynormalSeverityminorReproducibilityhave not tried
Status resolvedResolutionfixed 
Target Version2.18.0 
Summary0002126: Sort out / update asdcplib branch (after some of my changes got merged to their github)
Description

[]

TagsNo tags attached.
Branch[asdcplib]dcpomatic-2.13.0 [libdcp,dcpomatic]new-asdcplib
Estimated weeks required
Estimated work requiredMedium

Activities

carl

2023-03-02 22:44

administrator   ~0005545

i.e. rebase required changes on top of upstream master

carl

2024-03-16 20:01

administrator   ~0006352

Last edited: 2024-03-16 21:24

waf / pkg-config
bd785a7 waf build system.
424cb7a Naming fixes; add debug option.
232dceb Missing file.
06834d6 Upgrade waf to a version which works on recent Arch.
6c88c6e Make sure that .pc file specifies -DKM_WIN32 on Windows.
22cfc44 Missing edit to libasdcp-cth.pc.in.
cc2f56b Fix build on old GCCs.
8204f14 Don't include micro version number in MXFs we write.
dfb6aa3 Move public headers into src/asdcp and install them in a asdcp subdirectory.
ab0c4cc Make the IMP stuff usable.
867eb56 Install KM_log.h
3b098c4 Update waf.
48cf75a No-commit versioning.
9a56728 Try to provide python3 compatibility.
6c951dd Debug.
bc9484b Re-fix python3 wscript problem.
b8d5991 Build fix.
aa12a6d added readme for cth branch/fork
b9f1b2f Allow waf to be run with python 3.
0890f62 Remove unused file.
d4bf40b Rename .pc template file.
5d432cf Use -carl rather than -cth to match the git branch name.
8256396 Also need the flag in the actual build.
bb09615 Remove gcc 4.1 check and hide some more warnings.
02d8f88 Add -x32/-x64 suffix to boost libraries when building for Windows.
c78ff82 Fix include paths.
e0440b6 Whitespace fixes.
aab544c Build asdcp-{un,}wrap
a276ed1 Fix static build.
825e475 Bump waf for Python 3.10 compatibility.
ae75eb4 Fix writing of versions to .pc files.

Fixes could try to merge
DONE 9b5b13a Set up MXF header value DisplayHeight. Otherwise mediainfo reports 0 height for DCP-o-matic's MXFs. See DoM bug 0001325 for more discussion

Features / fixes difficult to merge
DONE d273907 Add another OpenReadFrame method for JP2K::CodestreamParser.
DONE 17fddfc Remove edit rate checks so that DCP-o-matic can use any edit rate it wants.
DONE 85eba79 Fix UTF-8 filename handling; replace DirScanner code with boost-based implementation.
DONE c6a91f5 Win32 build fixes.
DONE 0aa9691 cAllow overwrite (i.e. continue) when writing JPEG2000 MXFs.
DONE 565f3a6 Probably fix fake-writing with 3D.
DONE 9343b09 Support hashing while writing MXFs.
DONE f2ad6d5 Patches for testing to allow predictable random number and date generation.
DONE ee04871 Use boost random for the test (repeatable) RNG rather than rand_r.
DONE d3dbfda Add cscript file.
DONE 4b03c8f Build statically on Linux.
DONE 06cd028 Build correctly-suffixed libs (with -cth).
DONE 4d1b1c3 Allow > 60 fps 3D.
DONE a7e1d77 Quell some valgrind errors.
DONE 8f23c6c Add another VALGRIND_MAKE_MEM_DEFINED.
DONE 97918d8 Remove MSVC-ism; I think this is safe, and these methods are only used for debug logging anyway as far as I can see.
DONE c5b8b7e Log actual error codes from CreateFileW failures.
DONE 42342ba Add some more logging to RESULT_WRITEFAIL cases.
DONE 3ef6536 Fix mistakes in valgrind-supporting code.
DONE 8a4a2f2 Hackily fix use of undefined variable if !ASDCP_SUCCESS(result) here.

Merged / fixed / no longer necessary
6eff475 Fix missing initializer for the second variable in TagValue.
7861300 Remove unused parameters to methods.
62e2948 Fix enum switch/case statements with unhandled values.
5174e4a Fix unnecessary const qualifiers on return values.
8ec31f1 Add call to parent constructor.
3ac58e7 Remove some unused variables.
cdbaa07 Fix uninitialised variable.
eb10cbf Fix apparent typo in operator==.
0ff1c0b Remove use of stringstream in FileWriter.
04cf448 Remove stack-allocated BIGNUM which is no longer allowed in OpenSSL 1.1.
a985cd9 Remove some bad defines.

Warning fixes (maybe merged, didn't bother to check)
418bff6 Fix constructor initializer order.
d3e793c Fix some comparisons of signed with unsigned.
ea66f5b Fix a type-punning warning.
86cfe37 Add .gitignore.
9c508f6 Fix / hide some warnings on Linux.
3aaea6c Fix a few compiler warnings about misleading indents.
7a2a3c2 Remove pragma unknown by mingw.
4ebbe02 Re-add WIN32_LEAN_AND_MEAN for the asdcplib build.
2574dca DCP-o-matic already defines WIN32_LEAN_AND_MEAN; fix warning about this.
ee2ba36 Remove use of deprecated register keyword.
b9daf31 Remove uses of register.

carl

2024-03-16 21:25

administrator   ~0006353

dcpomatic-2.13.0 branch of asdcplib ready to try.

carl

2024-03-22 22:21

administrator   ~0006357

32b5af27f00f80054ab0f502ebd7b8a3fa0d4061

Bug History

Date Modified Username Field Change
2021-11-15 15:53 carl New Bug
2021-12-05 23:16 carl Status new => acknowledged
2021-12-05 23:16 carl Estimated work required => Medium
2022-12-16 23:46 carl Branch => [asdcplib]carl-3
2022-12-19 09:19 carl Branch [asdcplib]carl-3 => [asdcplib]carl-3, [libdcp]asdcp-master
2023-03-02 22:44 carl Note Added: 0005545
2024-03-16 19:30 carl Branch [asdcplib]carl-3, [libdcp]asdcp-master => [asdcplib]carl-3, [libdcp]asdcp-master, [asdcplib]dcpomatic-2.13.0
2024-03-16 20:01 carl Note Added: 0006352
2024-03-16 21:24 carl Note Edited: 0006352
2024-03-16 21:25 carl Note Added: 0006353
2024-03-17 19:39 carl Assigned To => carl
2024-03-17 19:39 carl Status acknowledged => in progress
2024-03-20 22:21 carl Branch [asdcplib]carl-3, [libdcp]asdcp-master, [asdcplib]dcpomatic-2.13.0 => [asdcplib]dcpomatic-2.13.0 [libdcp]new-asdcplib
2024-03-20 22:34 carl Branch [asdcplib]dcpomatic-2.13.0 [libdcp]new-asdcplib => [asdcplib]dcpomatic-2.13.0 [libdcp,dcpomatic]new-asdcplib
2024-03-21 22:03 carl Status in progress => tests running
2024-03-22 22:21 carl Status tests running => resolved
2024-03-22 22:21 carl Resolution open => fixed
2024-03-22 22:21 carl Note Added: 0006357