1920x1080 file that is cropped by 128 top and 128 bottom then fitted to DCI scope. Subtitles only go wrong when the crop is applied (see attached svg).

I think this is because we take a subtitle at some (w, h) from a 1920x1080 container so that the intermediate size is w/1920, h/1080.

Then scale these up by the container size so they end up w2048/1920 h858/1080 i.e. 1.067 times wider and 0.794 times taller i.e. same width and 0.744 of height.

Reporter said 54 becomes 41 i.e. 0.759 so that pretty much fits.

The picture hasn't changed aspect but the subtitles did. We need to scale subs the same as the image.

Sent build over email.

Apparently still broken; need to download stuff from FTP site sent by email.

Got SotD - need to run this and see if I can reproduce.

Obviously a problem with the preview and SotD after cropping and fitting to a scope frame (on main - need to check the branch).

SotD looks on on the branch - asked OP to check

OP confirms it's fixed.

6ac468554c7fea0dfaefde85fb6cdd0fceaf5cad

Still wrong if the source ratio is not the same as the DCP (e.g. 2.33:1 in a scope container).

Sent another build

OP replied on 13/3/24 saying there are no subtitles at all with this build, but didn't respond to follow-up questions.

Dropping priority after a month's radio silence.

Still broken.

Maybe it's because the subs are being added in a VF (i.e. make an OV from the bluray and then add the subs afterwards). Making an OV from "APOCALYPSE NOW" to see if this reproduces it.

This is of course because when we make the VF we import the MKV again but don't crop it (and anyway, video crop is ignored when scaling subs is video is being ignored for a particular file).

Need to stop ignoring video crop when video is ignored, and also do 0002808