View Bug Details
ID | Project | Category | View Status | Date Submitted | Last Update |
---|---|---|---|---|---|
0001293 | DCP-o-matic | Bugs | public | 2018-05-09 22:07 | 2018-10-17 20:16 |
Reporter | carl | Assigned To | carl | ||
Priority | urgent | Severity | major | Reproducibility | have not tried |
Status | closed | Resolution | fixed | ||
Target Version | 2.12.x | ||||
Summary | 0001293: SMPTE subs do not play on Alchemy and IMS2000 | ||||
Description | IMS2000: no error but no subs 2.12.4 is bad, 2.9.34 is OK. No obvious differences in the metadata between DCPs generated from these versions; Bad subtitle XML has different ReelNumber and "Unknown" for language rather than "Svenska" but nothing else obvious. | ||||
Tags | No tags attached. | ||||
Branch | |||||
Estimated weeks required | |||||
Estimated work required | Unknown | ||||
|
Testing revert of libdcp a18b9d20ac2a0353a4f1b0b78ce7a8e26fdd6aa8 to see if that makes any difference. |
|
Something I think I have seen in dcpomatic generated SMPTE subtitle XML:s is that the last timecode component is out of bounds (one more than the allowed value). Eg. 25 when EditRate is "25 1". This is not allowed, max allowed is 24 in this case. Sorry, can't find a sample right now. This component is called "E+" in 428-7. From SMPTE ST 428-7: 4.2.5 The HH field shall be encoded using two digits, with a value between 00 and 23 (inclusive). The MM and SS fields shall each be encoded using two digits, with a value between 00 and 59 (inclusive). The subtitle editable units field (E+) of a subtitle time code shall have a value between zero and “TimeCodeRate – 1” (inclusive). The number of digits to use for the E+ field shall match the minimum number of digits required to encode the value “TimeCodeRate – 1” (see Section 5.9). For example:
All ‘E+’ fields within a given DCDM Subtitle document shall be encoded using the same number of digits. The maximum value that can be expressed by a subtitle time code shall be 23:59:59:MaxE, where ‘MaxE’ is one number less than the value of TimeCodeRate element - encoded with the appropriate number of digits as defined above. Note: The formula to convert the above HH:MM:SS:E+ encoded value into the actual count of subtitle editable units is provided below: Count of subtitle editable units = (((((HH x 60) + MM) x 60) + SS) x TimeCodeRate) + E+ (...) 5.9 TimeCodeRate Element The value of the TimeCodeRate element shall be equal to the value of the EditRate element rounded to the nearest integer. For example: If the value of the EditRate element is “24000 1001”, then the value of the TimeCodeRate element will be 24. If the value of the EditRate element is “200 11”, then the value of the TimeCodeRate element will be 18. In case where the EditRate ratio corresponds exactly to the mid-point of two integer values (e.g., 23.5), then the value of the TimeCodeRate element shall be equal to the value of the EditRate The TimeCodeRate element shall encode the count of subtitle editable units for each increment of the seconds field (SS) of a subtitle time code — see Section 4.2.5. It shall be expressed as a positive (non-zero) integer value. |
|
Thanks @mhm, this could also be the cause: the bad subtitle file has out-of-range ticks but the good one does not. As it happens the test version I have sent out has both "fixes" (ticks rounding and , so if it works we should get Niclas to try plain 2.13.20. |
|
Hmm, the recent set of subtitle test DCPs I did were still INTEROP. I just installed 2.13.20 on my cinema test machine and will be able to do some testing on our ICMP on sunday. Our ICMP is running the very latest software.
|
|
Branch "niclas" which reverts a18b9d20ac2a0353a4f1b0b78ce7a8e26fdd6aa8 in libdcp (but also includes the timing fix for SMPTE ticks) fixes it. |
|
Current test version also works so it looks like the timing fix is the key. Needs backporting to 2.12.x with some urgency. |
|
Applied to v2.12.x and will be in v2.12.5. |
Date Modified | Username | Field | Change |
---|---|---|---|
2018-05-09 22:07 | carl | New Bug | |
2018-05-09 22:08 | carl | Note Added: 0002416 | |
2018-05-10 01:57 | mhm | Note Added: 0002417 | |
2018-05-10 23:23 | carl | Note Added: 0002418 | |
2018-05-10 23:23 | carl | Relationship added | related to 0001289 |
2018-05-11 17:11 | Carsten | Note Added: 0002420 | |
2018-05-11 17:13 | Carsten | Note Edited: 0002420 | |
2018-05-12 22:07 | carl | Note Added: 0002421 | |
2018-05-14 15:49 | carl | Note Added: 0002425 | |
2018-05-14 15:49 | carl | Note Edited: 0002425 | |
2018-05-14 15:49 | carl | Note Edited: 0002425 | |
2018-05-14 15:49 | carl | Priority | normal => urgent |
2018-05-14 23:20 | carl | Assigned To | => carl |
2018-05-14 23:20 | carl | Status | new => resolved |
2018-05-14 23:20 | carl | Resolution | open => fixed |
2018-05-14 23:20 | carl | Note Added: 0002427 | |
2018-10-17 20:16 | carl | Status | resolved => closed |