View Bug Details

IDProjectCategoryView StatusLast Update
0001638DCP-o-maticBugspublic2019-10-27 23:41
Reportercarl Assigned Tocarl  
PrioritynormalSeverityminorReproducibilityhave not tried
Status resolvedResolutionfixed 
Target Version2.16.0 
Summary0001638: Stop pointless re-writing of complete video assets
Description

I think this might just need a check on _first_non_existant_frame in the ReelWriterconstructor, then don't make a picture asset writer and deal with the fallout.

TagsNo tags attached.
Branch
Estimated weeks required
Estimated work requiredSmall

Relationships

related to 0000448 acknowledged Skip entire fake write pass if we have all video data 

Activities

carl

2019-10-23 23:22

administrator   ~0003497

Some work in v2.15.x-no-pointless-video-rewrite but needs some thinking about if encryption key changes between encodes (and maybe other stuff).

Carsten

2019-10-24 04:00

manager   ~0003499

Wasn't there something like a checklist about changed parameters. Does DCP-o-matic keep such a list for every video/audio file created? Then 'just' check for any changes of encoding parameters?

  • Carsten

carl

2019-10-24 10:02

administrator   ~0003500

Yes, it's encoded into the filename of the file in the video/ subdirectory. It doesn't currently take account of the encryption key. It's slightly worrying to use that "secret" key in the filename, but if we hash it it should be OK. And it's sitting there in plain text in the metadata.xml anyway!

carl

2019-10-27 23:41

administrator   ~0003506

895b386b6751afd3d068155f4ea71e762297672a in v2.15.x.

Bug History

Date Modified Username Field Change
2019-10-23 13:20 carl New Bug
2019-10-23 13:20 carl Tag Attached: next
2019-10-23 13:24 carl Estimated work required => Small
2019-10-23 13:24 carl Status new => acknowledged
2019-10-23 23:22 carl Note Added: 0003497
2019-10-24 04:00 Carsten Note Added: 0003499
2019-10-24 10:02 carl Note Added: 0003500
2019-10-24 22:59 carl Relationship added related to 0000448
2019-10-27 23:41 carl Assigned To => carl
2019-10-27 23:41 carl Status acknowledged => resolved
2019-10-27 23:41 carl Resolution open => fixed
2019-10-27 23:41 carl Note Added: 0003506
2019-10-27 23:41 carl Tag Detached: next