• member variables ending in _
• is std::system c++11?
• #ifdef it all?
• where did these JobManager::drop() calls come from?
• what's this pause/resume about?
• some camelCase names
• isFinal - maybe should be two methods?
• Gpu -> GPU in config XML?
• reading config values from J2K encoder thread not safe
• GrokContext memory management could be with a smart ptr?
• static grk_plugin::GrokInitializer grokInitializer dubious?
• c++11 compatibility in general
• setting a variable then saying (void)thevariable
• more shared ptr in general?
• boost::filesystem instead of std::string
• need osx prefs icon

Done

• couldn't stuff in gpu_config_panel.h be in a .cc?
• reading config options like GpuBinaryLocation needs to be optional

Oh my GOSH! I hadn't come across grok before. Is this looking like it's going to be pretty simple to integrate into DOM, or will it likely be a long time until this comes to fruition?

@carl J2KEncoder::_threads should maybe be a list of some other class hierarchy, maybe CPUEncoderThread, GPUEncoderThread, RemoteEncoderThread

But then with GPU we still want remote encoding presumably. And it's somehow nice if J2KEncoder deals with servers and then we have CPUJ2KEncoder and GrokJ2KEncoder underneath.

rearrange-encoder branch has one way to do this, but probably needs hand-applying on top of grok2

grok2 now has a wip commit that does the rearrangement - needs checking.

Now rebased onto 2.17.x