View Bug Details

Jump to NotesJump to History
IDProjectCategoryView StatusDate SubmittedLast Update
0002586DCP-o-maticMajor featurespublic2023-07-06 23:022024-11-08 23:04
Reportercarl Assigned Tocarl  
PrioritynormalSeverityminorReproducibilityN/A
Status resolvedResolutionfixed 
Target Version2.16.x 
Summary0002586: Support grok GPU acceleration
Description

Patches from Aaron applies to grok branches in dom and libdcp

TagsNo tags attached.
Branchgrok{,2} in DoM and grok in libdcp
Estimated weeks required
Estimated work requiredUndecided

Relationships

related to 0002605 acknowledgedcarl Option to limit the number of simultaneous remote encodes 
related to 0000328 acknowledged Use Nvidia CUDA to speedup render times 

Activities

carl

2023-07-07 00:03

administrator   ~0005850

Last edited: 2023-07-07 20:02
  • member variables ending in _
  • is std::system c++11?
  • #ifdef it all?
  • where did these JobManager::drop() calls come from?
  • what's this pause/resume about?
  • some camelCase names
  • isFinal - maybe should be two methods?
  • Gpu -> GPU in config XML?
  • reading config values from J2K encoder thread not safe
  • GrokContext memory management could be with a smart ptr?
  • static grk_plugin::GrokInitializer grokInitializer dubious?
  • c++11 compatibility in general
  • setting a variable then saying (void)thevariable
  • more shared ptr in general?
  • boost::filesystem instead of std::string
  • need osx prefs icon

Done

  • couldn't stuff in gpu_config_panel.h be in a .cc?
  • reading config options like GpuBinaryLocation needs to be optional

overlookmotel

2023-07-07 23:28

developer   ~0005853

Oh my GOSH! I hadn't come across grok before. Is this looking like it's going to be pretty simple to integrate into DOM, or will it likely be a long time until this comes to fruition?

carl

2023-07-09 23:41

administrator   ~0005854

@carl J2KEncoder::_threads should maybe be a list of some other class hierarchy, maybe CPUEncoderThread, GPUEncoderThread, RemoteEncoderThread

carl

2023-07-09 23:44

administrator   ~0005855

But then with GPU we still want remote encoding presumably. And it's somehow nice if J2KEncoder deals with servers and then we have CPUJ2KEncoder and GrokJ2KEncoder underneath.

carl

2023-09-10 21:57

administrator   ~0005942

rearrange-encoder branch has one way to do this, but probably needs hand-applying on top of grok2

carl

2023-09-23 23:34

administrator   ~0005956

grok2 now has a wip commit that does the rearrangement - needs checking.

carl

2023-09-23 23:35

administrator   ~0005957

Last edited: 2023-09-23 23:36

Now rebased onto 2.17.x

Bug History

Date Modified Username Field Change
2023-07-06 23:02 carl New Bug
2023-07-06 23:02 carl Assigned To => carl
2023-07-06 23:02 carl Status new => acknowledged
2023-07-06 23:03 carl Branch => grok
2023-07-06 23:03 carl Estimated work required => Undecided
2023-07-07 00:03 carl Note Added: 0005850
2023-07-07 08:51 carl Note Edited: 0005850
2023-07-07 10:03 carl Note Edited: 0005850
2023-07-07 10:06 carl Note Edited: 0005850
2023-07-07 19:52 carl Note Edited: 0005850
2023-07-07 20:02 carl Note Edited: 0005850
2023-07-07 23:28 overlookmotel Note Added: 0005853
2023-07-09 23:37 carl Branch grok => grok{,2}
2023-07-09 23:41 carl Note Added: 0005854
2023-07-09 23:44 carl Note Added: 0005855
2023-08-13 12:20 carl Target Version => 2.16.x
2023-09-03 23:37 carl Relationship added related to 0002605
2023-09-03 23:48 carl Branch grok{,2} => grok{,2} in DoM and grok in libdcp
2023-09-10 21:57 carl Note Added: 0005942
2023-09-23 23:34 carl Note Added: 0005956
2023-09-23 23:35 carl Note Added: 0005957
2023-09-23 23:36 carl Note Edited: 0005957
2024-01-03 12:54 carl Relationship added related to 0000328
2024-01-03 12:56 carl Status acknowledged => confirmed
2024-01-03 12:56 carl Category Features => Major features
2024-11-08 23:04 carl Status confirmed => resolved
2024-11-08 23:04 carl Resolution open => fixed