View Bug Details
ID | Project | Category | View Status | Date Submitted | Last Update |
---|---|---|---|---|---|
0002670 | DCP-o-matic | Bugs | public | 2023-11-27 22:07 | 2024-04-15 23:10 |
Reporter | carl | Assigned To | carl | ||
Priority | normal | Severity | major | Reproducibility | have not tried |
Status | feedback | Resolution | fixed | ||
Target Version | 2.16.x | ||||
Summary | 0002670: Subs from blu-ray are the wrong height | ||||
Description | e.g. a line is 54 pixels high in VLC but only 41 pixels high in the DCP. Not burnt in. | ||||
Tags | email, git-bug | ||||
Branch | 2670-subs,2670-again | ||||
Estimated weeks required | |||||
Estimated work required | Undecided | ||||
|
|
|
1920x1080 file that is cropped by 128 top and 128 bottom then fitted to DCI scope. Subtitles only go wrong when the crop is applied (see attached svg). |
|
I think this is because we take a subtitle at some (w, h) from a 1920x1080 container so that the intermediate size is w/1920, h/1080. Then scale these up by the container size so they end up w2048/1920 h858/1080 i.e. 1.067 times wider and 0.794 times taller i.e. same width and 0.744 of height. Reporter said 54 becomes 41 i.e. 0.759 so that pretty much fits. |
|
The picture hasn't changed aspect but the subtitles did. We need to scale subs the same as the image. |
|
Sent build over email. |
|
Apparently still broken; need to download stuff from FTP site sent by email. |
|
Got SotD - need to run this and see if I can reproduce. |
|
Obviously a problem with the preview and SotD after cropping and fitting to a scope frame (on main - need to check the branch). |
|
SotD looks on on the branch - asked OP to check |
|
OP confirms it's fixed. |
|
6ac468554c7fea0dfaefde85fb6cdd0fceaf5cad |
|
Still wrong if the source ratio is not the same as the DCP (e.g. 2.33:1 in a scope container). |
|
Sent another build |
|
OP replied on 13/3/24 saying there are no subtitles at all with this build, but didn't respond to follow-up questions. |
|
Dropping priority after a month's radio silence. |
Date Modified | Username | Field | Change |
---|---|---|---|
2023-11-27 22:07 | carl | New Bug | |
2023-11-27 22:07 | carl | Assigned To | => carl |
2023-11-27 22:07 | carl | Status | new => acknowledged |
2023-11-27 23:12 | carl | Target Version | => 2.16.70 |
2023-11-27 23:12 | carl | Estimated work required | => Undecided |
2023-11-27 23:12 | carl | Tag Attached: git-bug | |
2023-11-27 23:35 | carl | Tag Attached: email | |
2023-11-30 23:55 | carl | Note Added: 0006115 | |
2023-11-30 23:55 | carl | File Added: 2670.svg.gz | |
2023-11-30 23:56 | carl | Status | acknowledged => confirmed |
2023-11-30 23:56 | carl | Note Added: 0006116 | |
2023-12-01 00:22 | carl | Note Added: 0006117 | |
2023-12-01 00:24 | carl | Note Added: 0006118 | |
2023-12-01 20:25 | carl | Branch | => 2670-subs |
2023-12-01 20:54 | carl | Status | confirmed => feedback |
2023-12-01 20:54 | carl | Note Added: 0006121 | |
2023-12-02 19:58 | carl | Target Version | 2.16.70 => 2.16.71 |
2023-12-31 19:37 | carl | Target Version | 2.16.71 => 2.16.x |
2024-01-03 17:16 | carl | Status | feedback => acknowledged |
2024-01-03 17:16 | carl | Note Added: 0006187 | |
2024-01-03 17:16 | carl | Status | acknowledged => confirmed |
2024-01-09 13:07 | carl | Note Added: 0006214 | |
2024-01-09 14:04 | carl | Note Added: 0006215 | |
2024-01-09 14:08 | carl | Note Edited: 0006215 | |
2024-01-09 16:52 | carl | Status | confirmed => feedback |
2024-01-09 16:52 | carl | Note Added: 0006216 | |
2024-01-11 09:52 | carl | Status | feedback => tests running |
2024-01-11 09:52 | carl | Note Added: 0006230 | |
2024-01-12 11:07 | carl | Status | tests running => resolved |
2024-01-12 11:07 | carl | Resolution | open => fixed |
2024-01-12 11:07 | carl | Note Added: 0006242 | |
2024-03-03 19:37 | carl | Status | resolved => confirmed |
2024-03-03 19:37 | carl | Note Added: 0006338 | |
2024-03-04 17:16 | carl | Branch | 2670-subs => 2670-subs,2670-again |
2024-03-04 17:50 | carl | Status | confirmed => feedback |
2024-03-04 17:50 | carl | Note Added: 0006339 | |
2024-03-12 15:58 | carl | Note Edited: 0006339 | |
2024-04-15 23:09 | carl | Note Added: 0006369 | |
2024-04-15 23:09 | carl | Note Edited: 0006369 | |
2024-04-15 23:10 | carl | Priority | high => normal |
2024-04-15 23:10 | carl | Note Added: 0006370 |