View Bug Details

IDProjectCategoryView StatusLast Update
0002673DCP-o-maticPackagingpublic2024-01-13 10:02
Reportermarkusk Assigned Tocarl  
PrioritynormalSeverityblockReproducibilityalways
Status closedResolutionfixed 
Platform64-bitOSLinuxOS VersionArch
Product Version2.16.69 
Target Version2.16.70 
Summary0002673: ../src/wx/film_viewer.cc:356:26: error: ‘RtAudioError’ does not name a type; did you mean ‘RtAudioErrorType’?
Description

[322/446] Compiling src/wx/film_name_location_dialog.cc
../src/wx/film_viewer.cc: In member function ‘void FilmViewer::start_audio_stream_if_open()’:
../src/wx/film_viewer.cc:356:26: error: ‘RtAudioError’ does not name a type; did you mean ‘RtAudioErrorType’?
356 | } catch (RtAudioError& e) {
| ^~~~
| RtAudioErrorType
../src/wx/filmviewer.cc:360:150: error: ‘e’ was not declared in this scope
360 |
("There was a problem starting audio playback. Please try another audio output device in Preferences."), std_to_wx(e.what())
| ^
../src/wx/film_viewer.cc: In member function ‘void FilmViewer::config_changed(Config::Property)’:
../src/wx/film_viewer.cc:619:42: error: ‘RtAudioError’ does not name a type; did you mean ‘RtAudioErrorType’?
619 | } catch (RtAudioError&) {
| ^~~~
| RtAudioErrorType
../src/wx/film_viewer.cc:627:42: error: ‘RtAudioError’ does not name a type; did you mean ‘RtAudioErrorType’?
627 | } catch (RtAudioError&) {
| ^~~~
| RtAudioErrorType
../src/wx/film_viewer.cc:634:34: error: ‘RtAudioError’ does not name a type; did you mean ‘RtAudioErrorType’?
634 | } catch (RtAudioError&) {
| ^~~~
| RtAudioErrorType
../src/wx/film_viewer.cc:646:26: error: ‘RtAudioError’ does not name a type; did you mean ‘RtAudioErrorType’?
646 | } catch (RtAudioError& e) {
| ^~~~
| RtAudioErrorType
../src/wx/filmviewer.cc:650:124: error: ‘e’ was not declared in this scope
650 |
("Could not set up audio output. There will be no audio during the preview."), std_to_wx(e.what())
| ^

Waf: Leaving directory `/tmp/dcpomatic/src/dcpomatic-2.16.69/build'
Build failed
-> task in 'libdcpomatic2-wx' failed with exit status 1 (run with -v to display more information)
==> ERROR: A failure occurred in build().
Aborting...

Steps To Reproduce

compile on arch linux

Additional Information

Installed libs at time of compile

libasdcp-cth 0.1.6.r22.g8a4a2f2-1
libcxml 0.17.5-1
libdcp 1.8.88-1
libsub 1.6.44-1
rtaudio 6.0.1-1

TagsNo tags attached.
Branch
Estimated weeks required
Estimated work requiredUndecided

Activities

carl

2023-11-30 13:49

administrator   ~0006107

There is a substantial API break in RtAudio 6.0.0. How hard would it be to stay on an older RtAudio version (e.g. 4.x or 5.x)?

markusk

2023-11-30 14:44

reporter   ~0006108

It looks like only RtAudio 6.0.0 is supported in Arch and also AUR. This would result in us needing to supporting a 4.x or 5.x package. Which might conflict with some packages based on RtAudio 6.0 depend. Not a very big fan of doing that. I have not looked on how complex it would be create RtAudio 4.x or 5.x AUR package so far.

carl

2023-11-30 14:59

administrator   ~0006109

No problem, I just thought I would ask. I can change DoM to support either.

carl

2023-11-30 21:16

administrator   ~0006110

It should build with RtAudio 6 after 595d3ce932864fa5fb35cf9f52ac50178b8bd173 - let me know if not!

bradel

2023-11-30 22:06

reporter   ~0006111

Thank you for providing a patch that quickly! With the patch applied, DoM compiles under ArchLinux and works fine for me. However, I did not test the edge cases of missing/failing audio outputs...

Thanks again,
Cheers Benjamin

carl

2023-11-30 22:08

administrator   ~0006112

Thanks for checking it. I'll try and do some testing of the edge cases here.

Bug History

Date Modified Username Field Change
2023-11-30 11:17 markusk New Bug
2023-11-30 11:29 carl Status new => acknowledged
2023-11-30 11:29 carl Target Version => 2.16.70
2023-11-30 11:29 carl Estimated work required => Undecided
2023-11-30 13:49 carl Assigned To => carl
2023-11-30 13:49 carl Status acknowledged => feedback
2023-11-30 13:49 carl Note Added: 0006107
2023-11-30 14:44 markusk Note Added: 0006108
2023-11-30 14:44 markusk Status feedback => assigned
2023-11-30 14:59 carl Note Added: 0006109
2023-11-30 21:16 carl Status assigned => resolved
2023-11-30 21:16 carl Resolution open => fixed
2023-11-30 21:16 carl Note Added: 0006110
2023-11-30 22:06 bradel Note Added: 0006111
2023-11-30 22:08 carl Note Added: 0006112
2024-01-13 10:02 carl Status resolved => closed