View Bug Details
ID | Project | Category | View Status | Date Submitted | Last Update |
---|---|---|---|---|---|
0002589 | DCP-o-matic | Bugs | public | 2023-07-07 13:28 | 2023-12-22 00:56 |
Reporter | overlookmotel | Assigned To | carl | ||
Priority | urgent | Severity | minor | Reproducibility | always |
Status | feedback | Resolution | open | ||
Platform | Mac | OS | OS X | OS Version | 10.14 |
Product Version | 2.16.59 | ||||
Target Version | 2.16.x | ||||
Summary | 0002589: Thin black line on right or at bottom of preview | ||||
Description | Partial repeat of 0001947. Observed in DOM 2.16.59 on Mac OS 10.14.6 and Ubuntu 20.04. The preview in DOM GUI often shows a 1-pixel black line either on right or along bottom of preview pane. Whether it appears or not depends on the window size (which affects the scaling of the preview pane). But by adjusting the size of the window, it's possible to produce this in both flat and scope aspects. On Ubuntu, occasionally you can get a black line both down right-hand side and along bottom simultaneously. Some example images below. These are screenshots is from an iMac with a retina screen, so you'll probably need to zoom the images to see it clearly, as the lines are only 1 pixel wide. In this example I've used a TIFF file (attached below), but same effect is observable with any input e.g. ProRes or DCP. This effect was first seen in around 2.14.47, probably due to changes related to cropping of sub-sampled sources. It was fixed by 2.14.56, possibly by 0001872. But it seems to have reappeared in 2.16.x. A guess at the cause: Perhaps the size of preview pane is calculated based on window size x aspect ratio. But then actually rendering the image uses a different calculation, which rounds up/down in the opposite direction - so there's a 1 pixel discrepancy between the two and the black background shows through in the gap. Just to say, this is more important than it may sound, a least for my workflow. My standard procedure for cropping off letterboxing/pillarboxing is to set "Scale" to 1.85, crop until the picture is filling the whole preview window exactly (i.e. all black is gone) and then reverting "Scale" to "No stretch". This method is useful because: (1) The black bars will be pure black rather than possibly containing some small noise present in the original source due to imperfect compression and (2) DCP-o-matic then displays the exact active aspect ratio e.g. "Cropped to 1440x1080 (1.33:1)" and I can put that in the DCP name "F-133". The presence of the black line makes this difficult to do. But I don't know if anyone else would be using this slightly convoluted method, so maybe no-one else is really affected. | ||||
Tags | No tags attached. | ||||
Branch | 2589-lines | ||||
Estimated weeks required | |||||
Estimated work required | Small | ||||
|
|
|
Screenshot of Ubuntu 20.04 with black line bottom and on right visible. |
|
Hopefully improved in 91c86d50eb8a4a92e30736564c13bc4d11878f7f - hard to know for sure though. Let me know if you want to test it (and on which OS) and I'll make a build. |
|
Brilliant. Thanks Carl. Could you please make a test build for MacOS (13.4.1 Ventura)? Also, would a test build include other recent changes (0002569, 0002588, 0002584) so I can confirm they're fixed? |
|
Those other bugs you mention should all be fixed in 2.16.63. |
|
Ah ha. I hadn't spotted that 2.16.63 had dropped. Will test it out. |
|
Here's a build to see this bug is fixed: https://dcpomatic.com/temp/2589-lines/91c86d5/osx-10.10/DCP-o-matic%202589-lines-91c86d50e%20macOS10.10+.dmg |
|
Sorry, work is bananas, so not had time to test this yet. But have downloaded the test build, so feel free to delete it from server. Will come back as soon as I can. |
Date Modified | Username | Field | Change |
---|---|---|---|
2023-07-07 13:28 | overlookmotel | New Bug | |
2023-07-07 13:28 | overlookmotel | File Added: flat line on right.png | |
2023-07-07 13:28 | overlookmotel | File Added: flat line on bottom.png | |
2023-07-07 13:28 | overlookmotel | File Added: scope line on right.png | |
2023-07-07 13:28 | overlookmotel | File Added: scope line on bottom.png | |
2023-07-07 13:28 | overlookmotel | File Added: pink.tif | |
2023-07-07 13:37 | overlookmotel | Note Added: 0005851 | |
2023-07-07 13:37 | overlookmotel | File Added: scope line on right and bottom ubuntu.png | |
2023-07-08 15:41 | carl | Target Version | => 2.16.x |
2023-07-08 15:41 | carl | Estimated work required | => Undecided |
2023-07-08 15:41 | carl | Priority | normal => urgent |
2023-07-08 15:41 | carl | Assigned To | => carl |
2023-07-08 15:41 | carl | Status | new => acknowledged |
2023-09-01 15:57 | carl | Target Version | 2.16.x => 2.16.64 |
2023-09-02 23:57 | carl | Branch | => 2589-lines |
2023-09-02 23:57 | carl | Estimated work required | Undecided => Small |
2023-09-02 23:57 | carl | Status | acknowledged => confirmed |
2023-09-03 23:33 | carl | Note Added: 0005920 | |
2023-09-04 11:13 | overlookmotel | Note Added: 0005924 | |
2023-09-04 11:37 | carl | Note Added: 0005927 | |
2023-09-04 11:59 | overlookmotel | Note Added: 0005928 | |
2023-09-04 16:06 | carl | Note Added: 0005929 | |
2023-09-07 21:31 | carl | Status | confirmed => feedback |
2023-09-13 22:34 | carl | Target Version | 2.16.64 => 2.16.65 |
2023-09-21 00:08 | carl | Target Version | 2.16.65 => 2.16.66 |
2023-10-02 21:38 | carl | Target Version | 2.16.66 => 2.16.x |
2023-10-06 22:23 | overlookmotel | Note Added: 0005994 | |
2023-10-06 22:23 | overlookmotel | Status | feedback => assigned |
2023-12-22 00:56 | carl | Status | assigned => feedback |